Opened 9 years ago

Closed 9 years ago

#589 closed defect (invalid)

Seeing a discrepancy in SAO bandTable updation in JCTVC-I1003_d4.doc

Reported by: chinna.bommu Owned by: Chaitanya
Priority: major Milestone: WD6
Component: Text Version: D7 (I1003) d1
Keywords: Cc: chinna.bommu@…, bbross, wjhan, jct-vc@…

Description

If we see the calculation of bandTable it is updated as
for( k = 0; k < 4; k++ )

bandTable[ (k + saoLeftClass) & 31 ] = k + 1

so the array bandTable will contains values either 0 or 1 or 2 or 3 or 4.

we are calculating the variable bandidx like below.
The variable bandIdx is set equal to bandTable[ recPicture[ xC + i, yC + j ] >> bandShift ].

so bandidx can take any value among 0 or 1 or 2 or 3 or 4.

but the offset value what we have to add to the deblocked picture output will get from SaoOffsetVal[ cIdx ][ rx ][ ry ][ bandIdx ] .

here bandidx will take value among 0 or 1 or 2 or 3 but not 4.

So please have a look in to the updation of bandtable.

Thanks.

Regards,
Chaitanya Reddy

Change History (3)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc bbross wjhan jct-vc@… added

comment:2 Changed 9 years ago by chihming.fu

The array SaoOffsetVal is derived as follows.
SaoOffsetVal[ cIdx ][ rx ][ ry ][ 0 ] = 0 (7-66)
SaoOffsetVal[ cIdx ][ rx ][ ry ][ i + 1 ] = offsetSign*sao_offset_abs[ cIdx ][ rx ][ ry ][ i ] << ( bitDepth – Min( bitDepth, 10 ) ) (7-67)

Therefore, bandidx can take any value among 0 or 1 or 2 or 3 or 4 for SaoOffsetVal.

comment:3 Changed 9 years ago by bbross

  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Benjamin Bross(Subscriber, Participant)
  • Chih-Ming Fu(Participant)
  • chinna.bommu@…(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Always)
  • Woo-Jin Han(Subscriber)