Opened 13 years ago Closed 12 years ago #560 closed defect (fixed)Intra transform skipping semantic issue with high bit-depth
Description
As of Draft 7 (d2), Attachments (3)Change History (13)comment:1 Changed 13 years ago by DefaultCC Plugin
comment:2 Changed 13 years ago by bbross
Changed 13 years ago by cuilinglancomment:3 Changed 13 years ago by cuilinglan
Thanks for pointing out this problem. We have modified the spec and the corresponding code as in the attachments. comment:4 Changed 13 years ago by pandrivon
Thanks for both patches (Draft and HM). comment:5 Changed 13 years ago by bbross
Text issue is fixed in draft 7 (JCVTC-I1003_d3.doc) comment:6 Changed 13 years ago by fbossen
Shouldn't there be a rounding offset (0.5) added for the case where a right shift occurs? This would be more consistent with the inverse transform process. Adding the offset would make the transform bypass process equivalent to using a transform equal to comment:7 Changed 12 years ago by pandrivon
I think that you are right Frank. comment:8 Changed 12 years ago by fbossen
SW fixed in r2483 comment:9 Changed 12 years ago by pandrivon
As both D7 and SW are now fixed, I think that all points addressed by this ticket are fixed thus ticket should be closed. comment:10 Changed 12 years ago by bbross
Correct. Text issue is fixed in draft 7 (JCVTC-I1003_d3.doc) Note: See
TracTickets for help on using
tickets. | This list contains all users that will be notified about changes made to this ticket. These roles will be notified: Reporter, Owner, Subscriber, Participant
|
In HM7.0, I found the following:
Void TComTrQuant::xTransformSkip( Pel* piBlkResi, UInt uiStride, Int* psCoeff, Int width, Int height )
{
#if FULL_NBIT
#else
#endif
}
Where MAX_TR_DYNAMIC_RANGE is defined as 15 and uiLog2TrSize is always equal to 2 since transform skip can only be applied to 4x4 intra blocks.
15-2=13 and consequently HM and draft text match.
The question is, how does this goes together with the restriction in bit_depth_luma/chroma_minus8 semantics?
"bit_depth_luma/chroma_minus8 shall be in the range of 0 to 6, inclusive."