Opened 9 years ago

Closed 9 years ago

#558 closed defect (fixed)

Erorr in TileId[] derivation loop

Reported by: adarsh Owned by: bbross
Priority: minor Milestone: D7
Component: Text Version: D7 (I1003) d2
Keywords: Cc: bbross, wjhan, jct-vc@…

Description

The derivation of array TileId[] is wrong in Sec. 6.5. I think the first two loops, that are

...
for( j = 0, tileId = 0; j <= num_tile_columns_minus1; j++ )

for( i = 0; i <= num_tile_rows_minus1; i++, tileId++ )

...

should be

...
for( j = 0, tileId = 0; j <= num_tile_rows_minus1; j++ )

for( i = 0; i <= num_tile_columns_minus1; i++, tileId++ )

...

If the existing loops are correct as they are, then the next two lines need to be corrected. Instead of

...

for( y = RowBd[ j ]; y < RowBd[ j + 1 ]; y++ )

for( x = ColBd[ i ]; x < ColBd[ i + 1 ]; x++ )

...

they should be

...

for( y = RowBd[ i ]; y < RowBd[ i + 1 ]; y++ )

for( x = ColBd[ j ]; x < ColBd[ j + 1 ]; x++ )

...

Because the length of RowBd[] and ColBd[] are num_tile_rows_minus1+2 and num_tile_columns_minus1+2, respectively.

Change History (3)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc bbross wjhan jct-vc@… added

comment:2 Changed 9 years ago by bbross

  • Milestone set to D7

This issue is fixed in the proposed SAO draft text: JCTVC-I0602 v4 (JCTVC-I0602_CDTexts_r3.doc) that will be incorporated in upcoming d3 of JCTVC-I1003.

comment:3 Changed 9 years ago by bbross

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in draft 7 (JCVTC-I1003_d3.doc)

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Adarsh Krishnan Ramasubramonian(Reporter)
  • Benjamin Bross(Owner, Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Always)
  • Woo-Jin Han(Subscriber)