Opened 9 years ago

Closed 9 years ago

#531 closed defect (fixed)

TComSampleAdaptiveOffset::m_uiSaoBitIncrease incorectly computed for bitDepth > 8

Reported by: ksebov Owned by:
Priority: minor Milestone: HM-9.0
Component: HM Version: HM-6.0
Keywords: SAO, bitDepth Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

I looks like the following lines (1456 to 1462 in TComSampleAdaptiveOffset.cpp) fell victim to some erroneous search/replace.

#if FULL_NBIT

m_uiSaoBitIncrease = g_uiBitDepth + (g_uiBitDepth-8) - min((Int)(g_uiBitDepth + (g_uiBitDepth-8)), 10);

#else

m_uiSaoBitIncrease = g_uiBitDepth + g_uiBitIncrement - min((Int)(g_uiBitDepth + g_uiBitIncrement), 10);

#endif

The problem appears fixed if they are changed to just:

m_uiSaoBitIncrease = g_uiBitDepth + g_uiBitIncrement - min((Int)(g_uiBitDepth + g_uiBitIncrement), 10);


Change History (3)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 9 years ago by ksebov

Forgot to mention that it only manifests itself if you #define FULL_NBIT 1 in the TypeDef.h

Last edited 9 years ago by ksebov (previous) (diff)

comment:3 Changed 9 years ago by davidf

  • Milestone set to HM-9.0
  • Resolution set to fixed
  • Status changed from new to closed

This was resolved in r2900

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)