Opened 9 years ago

Closed 9 years ago

#513 closed defect (fixed)

SAO Interleaving: Merge-up flag missing if above CU is first in the slice.

Reported by: bheng Owned by:
Priority: minor Milestone:
Component: HM Version: HM-6.2
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

The following code prevents merge-up when the above CU is the first CU in the current slice (cuAddrUpInSlice==0).

if ( (ry > 0) && (cuAddrUpInSlice>0||lfCrossSliceBoundaryFlag))
{
    m_pcEntropyCoderIf->codeSaoMergeUp(saoParam->saoLcuParam[compIdx][addr].mergeUpFlag);
}

This restriction does not seem to be necessary. The attached patch fixes the problem by changing the condition to cuAddrUpInSlice>=0.

Attachments (1)

sao_merge_up_bug.patch (1.1 KB) - added by bheng 9 years ago.
Fix to allow merge-up when above CU is first in the slice.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 9 years ago by bheng

Fix to allow merge-up when above CU is first in the slice.

comment:2 Changed 9 years ago by ksuehring

  • Version changed from HM-6.2rc1 to HM-6.2

comment:3 Changed 9 years ago by ksuehring

Can that issue be closed? The commit message of r2343 refers to this?

comment:4 Changed 9 years ago by bheng

  • Resolution set to fixed
  • Status changed from new to closed

Issue fixed in r2343.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Brian Heng(Reporter, Participant)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)