Opened 9 years ago

Closed 9 years ago

#402 closed defect (fixed)

Fix the clipping range in rdoSaoUnit

Reported by: chihming.fu Owned by:
Priority: minor Milestone: HM-7.0
Component: HM Version: HM-6.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

Void TEncSampleAdaptiveOffset::rdoSaoUnit (Line 1940)
Before:

m_iOffset[yCbCr][typeIdx][classIdx] = Clip3(-offsetTh, offsetTh, (Int)m_iOffset[yCbCr][typeIdx][classIdx]);

After:

m_iOffset[yCbCr][typeIdx][classIdx] = Clip3(-offsetTh, offsetTh-1, (Int)m_iOffset[yCbCr][typeIdx][classIdx]);

Attachments (1)

FixSaoClip.patch (894 bytes) - added by chihming.fu 9 years ago.
patch file to fix the bug

Download all attachments as: .zip

Change History (4)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 9 years ago by chihming.fu

patch file to fix the bug

comment:2 Changed 9 years ago by ksuehring

Can you say why this "-1" is needed? Is that aligned with the text? What has been tested? What was adopted?

I think in general the "Description" field should contain an actual description of the problem, not a reproduction of the proposed patch.

comment:3 Changed 9 years ago by davidf

  • Milestone changed from HM-6.1 to HM-7.0
  • Resolution set to fixed
  • Status changed from new to closed

This was resolved by r2382

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Chih-Ming Fu(Reporter)
  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)