Opened 10 years ago

Closed 8 years ago

#382 closed enhancement (wontfix)

SAO: interpretation of array dimensions is overloaded

Reported by: davidf Owned by:
Priority: minor Milestone:
Component: HM Version: HM-6.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

Various arrays are allocated based upon m_iNumTotalParts, derived from m_aiNumCulPartsLevel[m_uiMaxSplitLevel]:

  • m_iCount
  • m_iOffset
  • m_iOffsetOrg
  • m_iRate
  • m_iDist
  • m_dCost
  • m_iDistOrg
  • m_dCostPartBest
  • m_iTypePartBest

The two definitions are effectively:

  • m_iCount[numTotalParts]
  • m_iCount[numComponents]

r2080 fixes the case where numTotalParts < numComponents.

In general, this sort of overloading should be fixed.

Change History (3)

comment:1 Changed 10 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 10 years ago by ksuehring

  • Version changed from HM-6.0rc1 to HM-6.0

comment:3 Changed 8 years ago by fbossen

  • Resolution set to wontfix
  • Status changed from new to closed

Doesn't apply to recent version of HM since SAO code was rewritten

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Reporter, Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)