Opened 11 years ago

Closed 11 years ago

#37 closed defect (fixed)

GPB is not turned off when GPB=0

Reported by: wjhan Owned by: davidf
Priority: minor Milestone:
Component: HM Version:
Keywords: Cc: davidf, fbossen, ksuehring, jct-vc@…

Description

When --GPB=0 (or in configuration file), tool status shows GPB is turned off, but actually still B-slice is used instead of P-slice. (both in high-delay of GOP 8 and low-delay of GOP 1).

Maybe due to the new configuration processing system?

P.S. with LowDelayCoding=1, GPB option works. It's strange.

Change History (7)

comment:1 Changed 11 years ago by davidf

  • Owner set to davidf
  • Status changed from new to assigned

I shall investigate this.

comment:2 Changed 11 years ago by davidf

  • Status changed from assigned to accepted

I have been able to reproduce the issue:

--InputFile=/dev/zero --SourceWidth=64 --SourceHeight=64 --GOPSize=1 --FramesToBeEncoded=2 --GPB=0
...
TOOL CFG: ALF:1 IBD:1 HAD:1 SRD:1 RDQ:1 SQP:0 ASR:0 PAD:0 LDC:0 NRF:1 BQP:0 QBO:0 GPB:0 FEN:1 EdgePrediction:1 RQT:1 CIP:1 ROT:1 AIS:1 MRG:1 IMP:0 AMVRES:1 SPF:1 AMP:1

POC    0 ( I-SLICE, QP 32 )        416 bits [Y 99.9900 dB    U 99.9900 dB    V 99.9900 dB]  [ET     1 ] [L0 ] [L1 ]
POC    1 ( B-SLICE, QP 36 )        120 bits [Y 99.9900 dB    U 99.9900 dB    V 99.9900 dB]  [ET     1 ] [L0 0 ] [L1 0 ]

vs

--InputFile=/dev/zero --SourceWidth=64 --SourceHeight=64 --GOPSize=1 --FramesToBeEncoded=2 --GPB=0 --LowDelayCoding=1
...
TOOL CFG: ALF:1 IBD:1 HAD:1 SRD:1 RDQ:1 SQP:0 ASR:0 PAD:0 LDC:1 NRF:1 BQP:0 QBO:0 GPB:0 FEN:1 EdgePrediction:1 RQT:1 CIP:1 ROT:1 AIS:1 MRG:1 IMP:0 AMVRES:1 SPF:1 AMP:1

POC    0 ( I-SLICE, QP 32 )        416 bits [Y 99.9900 dB    U 99.9900 dB    V 99.9900 dB]  [ET     1 ] [L0 ] [L1 ]
POC    1 ( P-SLICE, QP 38 )        120 bits [Y 99.9900 dB    U 99.9900 dB    V 99.9900 dB]  [ET     0 ] [L0 0 ] [L1 ]

comment:3 Changed 11 years ago by davidf

I have identified the fault. Setting GOPSize nolonger implies RateGOPSize. If no RateGOPSize is set (ie, remains the default of -1), then RateGOPSize is set to GOPSize. However, the default configuration files are setting RateGOPSize.

The fix is to either not set RateGOPSize in the config files, or set it to the "default" of -1, which will restore the previous behaviour.

comment:4 Changed 11 years ago by davidf

  • Resolution set to fixed
  • Status changed from accepted to closed

This has been clarified in r138

comment:5 Changed 10 years ago by davidf

  • Component set to HM

Updating component after adding WD (Text) tickets

comment:6 Changed 10 years ago by davidf

  • Cc fbossen ksuehring added

comment:7 Changed 10 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Owner, Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)
  • Woo-Jin Han(Reporter)