Opened 13 years ago

Closed 13 years ago

#335 closed defect (fixed)

A bug in HM5.2 when using --PAD and FrameSkip together

Reported by: taoranlu Owned by: ksuehring
Priority: minor Milestone: HM-6.1
Component: HM Version: HM-5.2
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

The HM code (the latest version in the trunk) has an issue related to frame skipping with padding.
When the input video size is not the multiple of 16 we enable the --PAD option. If at the same time we set the FrameSkip parameter to a non-zero value, it will cause a wrong framesize computation for skipping. The skip function uses m_iSourceWidth and m_iSourceHeight which are the values after padding. It should be changed to the original image width and height for skipping.

The bug located in file:
TAppEncTop.cpp, line 226

in function Void TAppEncTop::xCreateLib()

current:

m_cTVideoIOYuvInputFile.skipFrames(m_FrameSkip, m_iSourceWidth, m_iSourceHeight);

should be:

m_cTVideoIOYuvInputFile.skipFrames(m_FrameSkip, m_iSourceWidth-m_aiPad[0], m_iSourceHeight-m_aiPad[1]);

Change History (3)

comment:1 Changed 13 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 13 years ago by ksuehring

  • Milestone changed from HM-5.2 to HM-6.1
  • Owner set to ksuehring
  • Status changed from new to assigned
  • Version set to HM-5.2

comment:3 Changed 13 years ago by ksuehring

  • Resolution set to fixed
  • Status changed from assigned to closed

The fix has been committed in r2159

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Owner, Subscriber, Participant, Always)
  • Taoran Lu(Reporter)