Opened 10 years ago

Closed 10 years ago

#315 closed defect (fixed)

Alignment of WD description and software about QP wrapping

Reported by: kchono Owned by:
Priority: minor Milestone: HM-6.0
Component: HM Version: HM-5.1
Keywords: QP wrapping Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

HM software misses the QP wrapping defined in WD text as follows:

QPY = ( ( ( QPY,PREV + cu_qp_delta +52+ 2*QpBdOffsetY )%( 52 + QpBdOffsetY ) ) - QpBdOffsetY (7‑21)

In CE4 common test settings, HM software does not send cu_qp_delta values that need the QP wrapping. So this fix does not change BD-rate results. In order to align WD description and software, it is recommended to fix this issue when HM-6.0 is released. Attachment is a patch to HM-5.1-dev-cleanup.

#define FIX_CU_DQP_WRAP 1 /< Fix wrapping of cu_qp_delta

#if FIX_CU_DQP_WRAP
#define RESET_QP_OFFSET 1 /< This macro shall be set equal to 0 or removed when JCTVC-H0400 is integrated.
#endif

There is another issue that the QpBdOffsetY may not be used appropriately in HM software. (This issue is also related to ticket #313.) It is recommended that the RESET_QP_OFFSET macro is also integrated into HM-6.0 in order to avoid its impact on the QP wrapping fix. Then RESET_QP_OFFSET macro should be removed when JCTVC-H0400 is integrated.

Attachments (2)

20120207-HM-5.1-dev-cleanup-dqp-wrap.patch (3.5 KB) - added by kchono 10 years ago.
201202208-HM-5.1-dev-cleanup-r1867-qp-wrap.patch (3.8 KB) - added by kchono 10 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 10 years ago by kchono

comment:2 Changed 10 years ago by kchono

I have uploaded a revised patch that use more appropriate names.

#define FIX_QP_WRAP 1 < Fix qp wrapping
#if FIX_QP_WRAP
#define SET_QP_BD_OFFSET_ZERO 1
< This macro shall be set equal to 0 or removed when QpBdOffsetY and QpBdOffsetC issues are resolved.
#endif

comment:3 Changed 10 years ago by ksuehring

  • Resolution set to fixed
  • Status changed from new to closed

A solution based on JVTVC-H0736 has been submitted to HM-5.2-dev-core (Keiichi Chono)

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • Keiichi Chono(Reporter, Participant)