Opened 11 years ago

Closed 11 years ago

#30 closed defect (fixed)

Compilation error when HHI_TRANSFORM_CODING=0

Reported by: wjhan Owned by: fbossen
Priority: minor Milestone:
Component: HM Version:
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

Compilation error due to the conflict between HHI_TRANSFORM_CODING macro and NEWVLC macro. It can be easily fixed (patch will be provided within today)

Attachments (1)

patch_Ticket30_TComTrQuant.patch (272 bytes) - added by wjhan 11 years ago.
Patch file for Ticket #30, TComTrQuant.cpp

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by wjhan

Patch file for Ticket #30, TComTrQuant.cpp

comment:1 Changed 11 years ago by wjhan

More detail: here is a part of code in TComTrQuant.cpp

#if NEWVLC

if ( m_iSymbolMode == 0)

xRateDistOptQuant_VLC(pcCU, plSrcCoef, pDstCoef, 8, 8, uiAbsSum, eTType, uiAbsPartIdx, indexROT);

else

#endif

xRateDistOptQuant(pcCU, plSrcCoef, pDstCoef, 8, 8, uiAbsSum, eTType, uiAbsPartIdx, indexROT);

Problem is that xRateDistOptQuant_VLC function assumes that HHI_TRANSFORM_CODING=1 and has related codes. Thus to solve the compilation error, it should be:

#if NEWVLC && HHI_TRANSFORM_CODING

if ( m_iSymbolMode == 0)

xRateDistOptQuant_VLC(pcCU, plSrcCoef, pDstCoef, 8, 8, uiAbsSum, eTType, uiAbsPartIdx, indexROT);

else

#endif

xRateDistOptQuant(pcCU, plSrcCoef, pDstCoef, 8, 8, uiAbsSum, eTType, uiAbsPartIdx, indexROT);

There are several places in TComTrQuant.cpp.

One remaining problem is that xRateDistOptQuant_VLC, which seems to be better RDOQ for VLC mode, is not called when HHI_TRANSFORM_CODING=0 case. But anyway in the current software, that case makes compilation error. So it's recommended to apply this patch to solve non-VLC mode, and the remaining problem should be addressed by xRateDistOptQuant_VLC contributor.

I attach the patch file for TComTrQuant.cpp

comment:2 Changed 11 years ago by fbossen

  • Owner set to fbossen
  • Status changed from new to accepted

comment:3 Changed 11 years ago by fbossen

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed in r130

comment:4 Changed 10 years ago by davidf

  • Component set to HM

Updating component after adding WD (Text) tickets

comment:5 Changed 9 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:6 Changed 9 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Owner, Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)
  • Woo-Jin Han(Reporter, Participant)