Opened 9 years ago

Closed 9 years ago

#278 closed defect (wontfix)

Bugs of NSQT integration in deblocking filter

Reported by: xzheng Owned by:
Priority: minor Milestone:
Component: HM Version: HM-5.0
Keywords: Cc: geertv@…, fbossen, ksuehring, davidf, jct-vc@…

Description

The bugs descripted below were reported by Van Der Auwera, Geert via JCT-VC reflector. The following is the related parts that cause bugs.

  1. TComLoopFilter::xGetBoundaryStrengthSingle()

...

if ( m_aapucBS[iDir][0][uiAbsPartIdx] && (pcCUQ->getCbf( uiPartQ, TEXT_LUMA, pcCUQ->getTransformIdx(uiPartQ)) != 0 | | pcCUP->getCbf( uiPartP, TEXT_LUMA, pcCUP->getTransformIdx(uiPartP) ) != 0) )
{

uiBs = 2;

}
else

...

In the case of NSQT, the functions getTransformIdx and getCbf will return the wrong data, because the NSQT "non-square quadtree" reuses "square quadtree" data structure in current HM.

  1. TComLoopFilter::xSetEdgefilterTU()

NSQT potentially splits a 16x4 or 4x16 TU further into 4x4 TUs. At xSetEdgefilterTU(), if non-square transform size is smaller than 8, the edges of 4x4 TUs will not be set to true.

The patch for the bug fixed is attached. Through the tests, no impact on coding performance compared to HM5.0.

Attachments (1)

patch_nsqt_deblocking_fixed.patch (38.7 KB) - added by xzheng 9 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf added

Changed 9 years ago by xzheng

comment:2 Changed 9 years ago by davidf

  • Cc jct-vc@… added

comment:3 Changed 9 years ago by davidf

  • Resolution set to wontfix
  • Status changed from new to closed

NSQT was removed from the spec.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • geertv@…(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)
  • xiaozhen(Reporter)