Opened 10 years ago

Closed 10 years ago

#258 closed defect (fixed)

Uninitialized variables in TComSlice

Reported by: csghone Owned by:
Priority: minor Milestone: HM-5.1
Component: HM Version: HM-5.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

In case sliceMode=1, some variables are left uninitialized in second slice onwards leading to invalid access and crash.

List of variables:
m_RefPicListModification.m_bRefPicListModificationFlagL0
m_RefPicListModification.m_bRefPicListModificationFlagL1
m_RefPicListModification.m_uiNumberOfRefPicListModificationsL0
m_RefPicListModification.m_uiNumberOfRefPicListModificationsL1

This initialization is needed as part of TComSlice::copySliceInfo() as well to fix the problem for sliceMode=1.

Attachments (2)

encoder_2.cfg (8.9 KB) - added by csghone 10 years ago.
modification_init_fix.patch (872 bytes) - added by jonatan 10 years ago.
Fix for the problem with uninitialized variables (for ref pic list modifications) in TComSlice when encoding multiple slices per picture.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf added

Changed 10 years ago by csghone

Changed 10 years ago by jonatan

Fix for the problem with uninitialized variables (for ref pic list modifications) in TComSlice when encoding multiple slices per picture.

comment:2 Changed 10 years ago by ksuehring

  • Resolution set to fixed
  • Status changed from new to closed

The patch was applied to HM-5.0-dev in r1703

comment:3 Changed 10 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Chaitanya S. Ghone(Reporter)
  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)