Opened 12 years ago

Closed 12 years ago

#252 closed defect (fixed)

code that does nothing

Reported by: kolya Owned by:
Priority: trivial Milestone: HM-5.1
Component: HM Version: HM-5.0rc1
Keywords: redundant code Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

line 128 in TComTrQuant.h does nothing:

m_iRem = (iQP + 6*g_uiBitIncrement)%6;

Change History (4)

comment:1 Changed 12 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf added

comment:2 Changed 12 years ago by kolya

line 128 in TComTrQuant.h does nothing:

m_iRem = (iQP + 6*g_uiBitIncrement)%6;

  • correction: it should look like

m_iRem = iQP % 6;

addition of multiple of 6 is redundant

comment:3 Changed 12 years ago by fbossen

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r1688

comment:4 Changed 12 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)
  • Nikolay Shlyakhov(Reporter, Participant)