Opened 9 years ago

Closed 9 years ago

#246 closed defect (fixed)

Chroma ALF bug caused by ALF_DC_OFFSET_REMOVAL in HM-5.0rc1

Reported by: chiayang_tsai Owned by: ksuehring
Priority: major Milestone: HM-5.0
Component: HM Version: HM-5.0rc1
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

When ALF_DC_OFFSET_REMOVAL is defined, the chroma ALF mode decision may have problem. The central coefficient is assigned using the wrong array index. This bug may affect common test condition.

In line 4855, TEncAdaptiveLoopFilter.cpp, in HM-5.0rc1 (rev. 1677)


Original

qh[num_coeff-2] = 1<<((Int)ALF_NUM_BIT_SHIFT);


Fixed

#if ALF_DC_OFFSET_REMOVAL
qh[num_coeff-1] = 1<<((Int)ALF_NUM_BIT_SHIFT);
#else
qh[num_coeff-2] = 1<<((Int)ALF_NUM_BIT_SHIFT);
#endif

Change History (4)

comment:1 Changed 9 years ago by ksuehring

  • Component changed from CHANGEME to HM
  • Milestone set to HM-5.0
  • Owner changed from davidf to ksuehring
  • Status changed from new to assigned
  • Version set to HM-5.0rc1

comment:2 Changed 9 years ago by ksuehring

  • Resolution set to fixed
  • Status changed from assigned to closed

Patch added to HM-4.1-dev in r1679

comment:3 Changed 9 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:4 Changed 9 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Chia-Yang Tsai(Reporter)
  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Owner, Subscriber, Participant, Always)