Opened 10 years ago

Closed 9 years ago

#231 closed defect (wontfix)

N-pass ALF bug when STAR_CROSS_SHAPES is defined in HM-4.0

Reported by: chiayang_tsai Owned by:
Priority: minor Milestone:
Component: HM Version: HM-4.1
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

When STAR_CROSS_SHAPES is defined, a bug is found when 2-pass ALF is enabled (ALFEncodePassReduction = 2).

The pointer (m_iPreviousFilterShape) should be assigned to the current buffer (m_iPreviousFilterShapeMethods[m_uiVarGenMethod]) after the best filter shape is decided.

This bug does not affect common test condition.

Solution for HM-4.0

In Line 2574, TEncAdaptiveLoopFilter.cpp, the following code should be inserted:

#if STAR_CROSS_SHAPES_LUMA
m_iPreviousFilterShape =m_iPreviousFilterShapeMethods[m_uiVarGenMethod];
#endif

Change History (4)

comment:1 Changed 9 years ago by davidf

Updating component after adding WD (Text) tickets

comment:2 Changed 9 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:3 Changed 9 years ago by davidf

  • Cc jct-vc@… added

comment:4 Changed 9 years ago by davidf

  • Resolution set to wontfix
  • Status changed from new to closed

ALF was removed from the spec

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Chia-Yang Tsai(Reporter)
  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)