Opened 10 years ago

Closed 10 years ago

#217 closed defect (fixed)

1-pass ALF problem when STAR_CROSS_SHAPES_LUMA is defined (Not affect common test condition))

Reported by: chiayang_tsai Owned by:
Priority: minor Milestone:
Component: HM Version: HM-4.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

This problem does not happen in common test condition. It only happens when g_uiMaxCUDepth is equal to 0 and 1-pass ALF is applied.

When STAR_CROSS_SHAPES_LUMA is defined, the selected filter shape for training new coefficients may be wrong.

solution

One-line fix. In Line 4851, TencAdaptiveLoopFilter.cpp, add the following code.

#if STAR_CROSS_SHAPES_LUMA

copyALFParam(m_pcTempAlfParam, &cAlfParam);

#endif

Change History (4)

comment:1 Changed 10 years ago by chiayang_tsai

  • Resolution set to fixed
  • Status changed from new to closed

Fix in r1416

comment:2 Changed 10 years ago by davidf

  • Component set to HM

Updating component after adding WD (Text) tickets

comment:3 Changed 10 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:4 Changed 10 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Chia-Yang Tsai(Reporter, Participant)
  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)