Opened 10 years ago

Closed 10 years ago

#183 closed defect (fixed)

Incorrect encoder slice size decisions when EntropySliceMode=2

Reported by: rickard Owned by:
Priority: minor Milestone: HM-3.2
Component: HM Version:
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

This is a problem in the HM-3.1-dev-dqp branch.

When using EntropySliceMode 2, i.e. fixed number of bits (for VLC) or bins (for CABAC) per slice, CompressCU will sometimes produce CU:s too large to fit in a slice, resulting in slices larger than the specified limit. This could be avoided if the encoder made the decision to split the CU (unless the CU is already of slice granularity size or smaller). A split decision check is already implemented in xCheckBestMode for regular slices, but no similar check is performed for entropy slices.

The fix for this would be to add a similar check for entropy slices. Note that for this to work for CABAC where a bin threshold is used, code to keep track of the number of bins encoded during compression is needed too.

Change History (6)

comment:1 Changed 10 years ago by rickard

  • Milestone set to HM-3.2

comment:2 Changed 10 years ago by rickard

A fix has been checked in (r1037) to HM-3.1-dev-dqp.
Then HM-3.1-dev-dqp was merged (r1039) into HM-3.1-dev

comment:3 Changed 10 years ago by ksuehring

  • Resolution set to fixed
  • Status changed from new to closed

closing based in rickards comment

comment:4 Changed 9 years ago by davidf

  • Component set to HM

Updating component after adding WD (Text) tickets

comment:5 Changed 9 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:6 Changed 9 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • Rickard Sjoberg(Reporter, Participant)