Opened 13 years ago

Closed 13 years ago

#167 closed defect (fixed)

JCTVC-E049 bugs about pixel maximum value of SAO output and the memory allocation of CABAC encoder

Reported by: chihming.fu Owned by:
Priority: minor Milestone: HM-3.1
Component: HM Version: HM-3.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

Using revision r928
In TComAdaptiveLoopFilter.cpp:2885, the maximun value of SAO output is 

  UInt uiMaxY  = 255   << g_uiBitIncrement;

The maximum value of SAO should use the variable consistent with the other part of HM-3.0 as following

  UInt uiMaxY  = g_uiIBDI_MAX;

In TEncTop.cpp:143, the variable g_uiMaxCUDepth is used to allocate the memory of variable m_pppcRDSbacCoder; however, SAO will re-use the variable m_pppcRDSbacCoder and therefore, the memory allocation process of pppcRDSbacCoder need set variable g_uiMaxCUDepth to 4 temporary.

Change History (5)

comment:1 Changed 13 years ago by chihming.fu

In TEncTop.cpp:99, the variable g_uiMaxCUDepth is used to allocate the memory of variable m_pppcRDSbacCoder; however, SAO will re-use the variable m_pppcRDSbacCoder and therefore, the memory allocation process of pppcRDSbacCoder need set variable g_uiMaxCUDepth to 4 temporary.

comment:2 Changed 13 years ago by fbossen

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r929

comment:3 Changed 12 years ago by davidf

  • Component set to HM

Updating component after adding WD (Text) tickets

comment:4 Changed 12 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:5 Changed 12 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Chih-Ming Fu(Reporter, Participant)
  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)