Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#165 closed defect (fixed)

Bug in update of Golomb-Rice parameter in TComTrQuant::xRateDistOptQuant function

Reported by: sandeepkanumuri Owned by:
Priority: minor Milestone: HM-3.1
Component: HM Version: HM-3.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

There is a bug in the update of Golomb-Rice parameter in the RDOQ function for CABAC.

The following buggy code occurs twice inside the function
if( uiAbs > 3 )
{

uiAbs -= 4;
uiAbs = min<UInt>( uiAbs, 15 );
uiGoRiceParam = g_aauiGoRiceUpdate[ uiGoRiceParam ][ uiAbs ];

}

and should be replaced with
if( uiAbs > 2 )
{

uiAbs -= 3;
uiAbs = min<UInt>( uiAbs, 15 );
uiGoRiceParam = g_aauiGoRiceUpdate[ uiGoRiceParam ][ uiAbs ];

}

However, the impact on coding efficiency by this bug fix appears to be negligible when tested on 49 frames. The corresponding excel sheet is attached.

Attachments (1)

HM3base_49f_BfE253.zip (108.5 KB) - added by sandeepkanumuri 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by sandeepkanumuri

comment:1 Changed 10 years ago by ksuehring

  • Milestone set to HM-3.1
  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed 10 years ago by ksuehring

fixed in r928

comment:3 Changed 10 years ago by davidf

  • Component set to HM

Updating component after adding WD (Text) tickets

comment:4 Changed 10 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:5 Changed 10 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • Sandeep Kanumuri(Reporter)