Opened 10 years ago

Closed 10 years ago

#153 closed defect (fixed)

Strange code in TDecTop::executeDeblockAndAlf()

Reported by: hao Owned by: davidf
Priority: trivial Milestone: HM-3.1
Component: HM Version: HM-3.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

In TDecTop::executeDeblockAndAlf(), a variable pcSlice is defined as follows.

TComSlice* pcSlice  = pcPic->getPicSym()->getSlice( m_uiSliceIdx                  );

The variable pcSlice always points non-existent Slice object, since m_uiSliceIdx is the last valid Slice index minus 1 when executeDeblockAndAlf() is called.
pcSlice is used for calling the member function sortPicList() but this usage is meaningless because sortPicList() is defined as a static function.

Therefore, pcSlice should be removed and the description

pcSlice->sortPicList( m_cListPic );

should be replaced with

TComSlice::sortPicList( m_cListPic );

Similar description is also found in TDecTop::xGetNewPicBuffer().

Change History (6)

comment:1 Changed 10 years ago by davidf

  • Milestone set to HM-3.1
  • Owner set to davidf
  • Status changed from new to accepted
  • Version set to HM-3.0

comment:2 Changed 10 years ago by davidf

Resolved by r946

comment:3 Changed 10 years ago by davidf

  • Resolution set to fixed
  • Status changed from accepted to closed

comment:4 Changed 10 years ago by davidf

  • Component set to HM

Updating component after adding WD (Text) tickets

comment:5 Changed 10 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:6 Changed 10 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Owner, Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • Hirofumi Aoki(Reporter)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)