Opened 4 years ago

Closed 4 years ago

#1482 closed defect (fixed)

bitstream syntax in wrong order

Reported by: swong10 Owned by:
Priority: major Milestone:
Component: HM SCC Version:
Keywords: Cc: lidong.xu@…, samuel.wong@…, jct-vc@…

Description

The syntax "cu_chroma_qp_offset_enabled_flag" is in wrong order with the other group of three syntax "slice_act_y_qp_offset" , "slice_act_cb_qp_offset" and "slice_act_cr_qp_offset"

HM reference model mismatches with the written HEVC SCC spec.

But the HM Encoder and Decoder matches. So, the same fix needs to apply to both encoder and decoder.

HM Decoder/Encoder 16.15_SCM8.4 :
TDecCAVLC.cpp -> Void TDecCavlc::parseSliceHeader()
TEncCavlc.cpp -> Void TEncCavlc::codeSliceHeader()

The order should be as follows :
if( pcSlice->getPPS()->getPpsScreenExtension().getUseSliceACTOffset() )

{

WRITE_SVLC( pcSlice->getSliceActQpDelta(COMPONENT_Y), "slice_act_y_qp_offset");
WRITE_SVLC( pcSlice->getSliceActQpDelta(COMPONENT_Cb), "slice_act_cb_qp_offset");
WRITE_SVLC( pcSlice->getSliceActQpDelta(COMPONENT_Cr), "slice_act_cr_qp_offset");

}

if (pcSlice->getPPS()->getPpsRangeExtension().getChromaQpOffsetListEnabledFlag())

{

WRITE_FLAG(pcSlice->getUseChromaQpAdj(), "cu_chroma_qp_offset_enabled_flag");

}

Change History (2)

comment:1 Changed 4 years ago by swong10

The code segment provided is for encoder only.
The mismatch is in the Slice Header encode/decode.

comment:2 Changed 4 years ago by libin

  • Resolution set to fixed
  • Status changed from new to closed

fixed in r4931.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Bin Li(Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Always)
  • lidong.xu@…(Subscriber)
  • Samuel Wong(Reporter, Subscriber, Participant)