Opened 7 years ago

#1464 new defect

local RPS usage in arrangeLongtermPicturesInRPS

Reported by: Tomohiro Ikai Owned by:
Priority: minor Milestone:
Component: HM Version: HM-16.13
Keywords: Cc: ksuehring, davidf, karlsharman, jct-vc@…

Description

With the change of #4483 (corresponding to HM-16.6), local RPS(pcSlice->getLocalRPS()) became used instead of pcSlice->getRPS() in arrangeLongtermPicturesInRPS().
#The change also involves const for pcSlice->getRPS().

But the original implementation (seems from HM-7.1 for I0342, #define CODE_POCLSBLT_FIXEDLEN) would only work with pcSlice->getRPS(), because in many cases local RPS would be empty (not initialalized/set). Exception cases (local RPS can be valid) would be that createExplicitReferencePictureSetFromReference is called beforehand in TEncGOP.cpp due to a loss detection (return non-zero in checkThatAllRefPicsAreAvailable or IRAP. The createExplicit... prepares local RPS.

The patch (relative to HM-16.13) may resolve this issue.

two possible options:
FIX_LOCAL_RPS==1: revert local RPS usage, which needs const removal (not included in the patch for the removal part)
FIX_LOCAL_RPS==2: copy pcSlice->getRPS() data to local RPS (if needed) and use local RPS.

Note: the issue is not related to CTC. The fix may not be good enough..(i not so familiar with this area)

Attachments (1)

fix_localRPS.patch​ (1.4 KB) - added by Tomohiro Ikai 7 years ago.

Download all attachments as: .zip

Change History (1)

Changed 7 years ago by Tomohiro Ikai

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)
  • Tomohiro Ikai(Reporter)