Opened 4 years ago

Closed 3 months ago

#1452 closed defect (fixed)

HEVC SCC Text transform unit syntax for chroma_qp_offset call is missing chromaCbf and !cu_transquant_bypass conditions

Reported by: leendert Owned by:
Priority: critical Milestone:
Component: SCC text Version:
Keywords: Cc: jill.boyce@…, samuel.wong@…, rajan_joshi, jct-vc@…

Description

The changes introduced to support SCC in the transform unit syntax table have modified the condition for chroma QP offset coding compared to Rext.

In Rext the condition for coding cu_chroma_qp_offset_flag and cu_chroma_qp_offset_idx include the cbfChroma and !cu_transquant_bypass_flag values. In SCC the coding of these syntax elements was moved to chroma_qp_offset() to share with palette coding. However, since the aforementioned variables are no longer present in chroma_qp_offset() these conditions should be added in transform unit before calling chroma_qp_offset().

The current wording in JCTVC-W1005-v3.doc is that chroma QP offset gets coded inside transform unit even when cbfChroma is 0 or cu_transquant_bypass_flag is 1. This mismatches with the HM model and Rext behavior.

Rext transform unit syntax:

if( cu_chroma_qp_offset_enabled_flag  &&  cbfChroma  &&
    !cu_transquant_bypass_flag  &&  !IsCuChromaQpOffsetCoded ) {
    cu_chroma_qp_offset_flag
    if( cu_chroma_qp_offset_flag  &&  chroma_qp_offset_list_len_minus1 > 0 )
        cu_chroma_qp_offset_idx
}

SCC transform unit syntax table:

if( cbfLuma  | |  cbfChroma ) {
    <removed for brevity>
    delta_qp( )
    chroma_qp_offset( )

SCC chroma QP offset syntax:

chroma_qp_offset( ) {
    if( cu_chroma_qp_offset_enabled_flag  &&  !IsCuChromaQpOffsetCoded ) {
        cu_chroma_qp_offset_flag
        if( cu_chroma_qp_offset_flag  &&  chroma_qp_offset_list_len_minus1 > 0 )
            cu_chroma_qp_offset_idx
    }
}

Change History (2)

comment:1 Changed 3 months ago by karlsharman

Was corrected between JCTVC-W1005-v3 and -v4 by adding the condition on "cbfChroma && !cu_transquant_bypass_flag".

comment:2 Changed 3 months ago by crosewarne

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • jct-vc@…(Subscriber)
  • jill.boyce@…(Subscriber)
  • Karl Sharman(Participant)
  • karl.sharman@…(Always)
  • Karsten Suehring(Always)
  • Leendert van den Berg(Reporter)
  • Rajan Joshi(Subscriber)
  • samuel.wong@…(Subscriber)