Opened 10 years ago

Closed 10 years ago

#143 closed defect (fixed)

(E049) When ALF off and SAO on, setUseNonCrossAlf(flag) is not set before calling ALF process

Reported by: davidf Owned by:
Priority: major Milestone: HM-3.1
Component: HM Version: HM-3.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

Using revision r804

In TEncGop.cpp:385, setting of non-cross-ALF is guarded by ALF being in use:

      if(pcSlice->getSPS()->getUseALF())
      {
       ...
      }

Later, however, at around line 509:

#if MTK_SAO
          if ( pcSlice->getSPS()->getUseALF() || (pcSlice->getSPS()->getUseSAO()) )
...
            m_pcAdaptiveLoopFilter->startALFEnc(pcPic, m_pcEntropyCoder );

The ALF process is called without the correct state being set.

Change History (5)

comment:1 Changed 10 years ago by davidf

  • Milestone changed from HM-3.0 to HM-3.1
  • Version set to HM-3.0

comment:2 Changed 10 years ago by davidf

  • Resolution set to fixed
  • Status changed from new to closed

This has been fixed in r842

comment:3 Changed 9 years ago by davidf

  • Component set to HM

Updating component after adding WD (Text) tickets

comment:4 Changed 9 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:5 Changed 9 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Reporter, Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)