Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#1410 closed defect (fixed)

Memory leak in TEncGOP::xCreatePictureTimingSEI

Reported by: Vadim Owned by:
Priority: minor Milestone: HM-16.7
Component: HM Version: HM-16.5
Keywords: Cc: ksuehring, davidf, karlsharman, jct-vc@…

Description

SEIPictureTiming *pictureTimingSEI = new SEIPictureTiming();

The object is created, however it is used conditionally later on, so then condition is false memory seems not freed.

Attached patch may solve the problem.

Attachments (1)

xCreatePictureTimingSEI.patch (1.1 KB) - added by Vadim 6 years ago.
xCreatePictureTimingSEI.patch

Download all attachments as: .zip

Change History (4)

comment:1 Changed 6 years ago by DefaultCC Plugin

  • Cc ksuehring davidf karlsharman jct-vc@… added

Changed 6 years ago by Vadim

xCreatePictureTimingSEI.patch

comment:2 Changed 6 years ago by ksuehring

  • Resolution set to fixed
  • Status changed from new to closed

Thanks for spotting this.

I think in general, the overall SEI generation code can probably still be improved, but for now the patch should solve the memory leak.

Fixed in r4589

comment:3 Changed 5 years ago by ksuehring

  • Milestone set to HM-16.7
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • Vadim Seregin(Reporter)