Opened 5 years ago

Closed 5 years ago

#1392 closed defect (fixed)

ARM cross-compilation issues with g++/Linux

Reported by: ksuehring Owned by:
Priority: minor Milestone: HM-16.7
Component: HM Version: HM-16.4
Keywords: Cc: ksuehring, davidf, karlsharman, jct-vc@…

Description (last modified by ksuehring)

The following code has been added to address issue #206

#ifdef __arm__
typedef       signed char         Char;
#else
typedef       char                Char;
#endif

It has been reported that defining Char to "signed char" created compilation issues in related to I/O functions in TVideoIOYuv.cpp/.h.

These can be addressed by removing the special case for ARM in typedef.h

There may still exist arithmetic problems with signed vs. unsigned calculations (as reported in #206).

Attachments (1)

replaceCharWithSCharAndTChar.patch (83.9 KB) - added by karlsharman 5 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 years ago by DefaultCC Plugin

  • Cc ksuehring davidf karlsharman jct-vc@… added

comment:2 Changed 5 years ago by dfsouza

It will work with the GCC flag -fsigned-char.

Changed 5 years ago by karlsharman

comment:3 Changed 5 years ago by karlsharman

I have attached a patch that replaces the troublesome Char type with
an SChar (signed char) that is used for arithmetic operations and
TChar (just 'char') that is used for text-based operations.

A user of ARM gcc has reported that this resolves the issue.

The original problem was that 'char' (Char) types are signed
on some compilers and unsigned on others, leading to arithmetic
problems.

This patch (relative to HM-dev r4445) resolves this ambiguity.

comment:4 Changed 5 years ago by ksuehring

  • Milestone set to HM-16.7

comment:5 Changed 5 years ago by ksuehring

  • Description modified (diff)

comment:6 Changed 5 years ago by karlsharman

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r4590.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Diego Felix de Souza(Participant)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Subscriber, Participant)
  • karl.sharman@…(Always)
  • Karsten Suehring(Reporter, Subscriber, Participant, Always)