Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#1389 closed defect (worksforme)

possible memory issue

Reported by: kolya Owned by:
Priority: minor Milestone: HM-16.6
Component: HM Version: HM-16.4
Keywords: Cc: ksuehring, davidf, karlsharman, jct-vc@…

Description

It seems (I am not sure) that in TDecCU::create (TDecCu.cpp line 82) there is wrong loop condition: it should be <= rather that <, coz when m_uiMaxDepth == 1 there is no memory allocation.

Change History (3)

comment:1 Changed 6 years ago by DefaultCC Plugin

  • Cc ksuehring davidf karlsharman jct-vc@… added

comment:2 Changed 6 years ago by karlsharman

  • Resolution set to worksforme
  • Status changed from new to closed

There does not appear to be a bug in this part of the code,
except that sometimes there are more allocations than
there needs to be:

The arrays (m_ppcYuvResi, m_ppcYuvReco, m_ppcCU) have data allocated
for each possible depth of the CU/TU tree, except the last.

These arrays are only used for the CU tree.

Since the minimum TU size must be less than the minimum CU size,
there is always enough entries for the CU tree.

A comment (& TODO) has been added to the software in r4445.

comment:3 Changed 5 years ago by ksuehring

  • Milestone set to HM-16.6
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Subscriber, Participant)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • Nikolay Shlyakhov(Reporter)