Opened 6 years ago

Closed 6 years ago

#1364 closed defect (fixed)

Wrong assert(0) in decoder

Reported by: gregory Owned by:
Priority: minor Milestone: HM-16.3
Component: HM Version: HM-16.2
Keywords: Cc: ksuehring, davidf, karlsharman, jct-vc@…

Description

Function TDecTop::decode has an assert(0) if it encounters NAL unit of reserved or unspecified types. But specification requires decoder to ignore such NAL units:

"For purposes other than determining the amount of data in the decoding units of the bitstream (as specified in Annex C), decoders shall ignore (remove from the bitstream and discard) the contents of all NAL units that use reserved values of nal_unit_type."

Change History (4)

comment:1 Changed 6 years ago by DefaultCC Plugin

  • Cc ksuehring davidf karlsharman jct-vc@… added

comment:2 Changed 6 years ago by ksuehring

That's basically test code which can indeed be removed. We also had this for a few NAL unit types that were not implemented before (see #1265). I guess, it would be nice to print a warning that something "unknown" was seen by the decoder.

comment:3 Changed 6 years ago by ksuehring

  • Milestone set to HM-16.3

comment:4 Changed 6 years ago by ksuehring

  • Resolution set to fixed
  • Status changed from new to closed

The issue has been fixed in r4265

  • ignore reserved and unspecified NAL units in decoding process
  • print a note that a reserved or unspecified NAL units was encountered
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Gregory Shimansky(Reporter)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)