Opened 6 years ago

Closed 6 years ago

#1360 closed defect (duplicate)

no syntax reading in code

Reported by: kolya Owned by:
Priority: trivial Milestone: HM-16.3
Component: HM Version: HM-16.2
Keywords: Cc: ksuehring, davidf, karlsharman, jct-vc@…

Description

There is no reading of colour_plane_id in HM-dev reference s\w, which is in the spec:

slice_type ue(v)
if( output_flag_present_flag )

pic_output_flag u(1)

if( separate_colour_plane_flag = = 1 )

colour_plane_id u(2)

Change History (6)

comment:1 Changed 6 years ago by DefaultCC Plugin

  • Cc ksuehring davidf karlsharman jct-vc@… added

comment:2 Changed 6 years ago by karlsharman

  • Priority changed from major to trivial

No currently defined conformant bit-stream can have the separate_colour_plane_flag set, and the code will assert if it is set. So is there anything to fix?

comment:3 Changed 6 years ago by kolya

It seems that assert is working in DEBUG mode only, or you need to make some actions. Thus, it does not protect to the full extent. The reported issue is only to report that reference s\w differs from the spec.

comment:4 Changed 6 years ago by ksuehring

The representation information of colour plane information in the syntax was very generic from the beginning and always only constraint by profile/level.

In our build environment asserts are enabled also on release mode (with minor speed impact). We rely heavily on them in various places, so building without them would require changes throughout the software.

In general we need to improve PTL checking, but unless we have started a generic implementation, I don't think we need to change this check.

comment:5 Changed 6 years ago by kolya

Okay, I am using a kind of different build environment. Thank you for clarification.

comment:6 Changed 6 years ago by karlsharman

  • Resolution set to duplicate
  • Status changed from new to closed

Added to #1367. Closed as duplicate.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Subscriber, Participant)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • Nikolay Shlyakhov(Reporter, Participant)