Opened 8 years ago

Closed 8 years ago

#1354 closed enhancement (fixed)

right syntax elements naming in reference software

Reported by: kolya Owned by:
Priority: minor Milestone: HM-16.3
Component: HM Version: HM-16.2
Keywords: syntax Cc: ksuehring, davidf, karlsharman, jct-vc@…

Description

It is proposed to fix syntax naming in TDecCAVLC.cpp for it to match specification text for the sake of easier debugging etc. Relevant patches are applied.

Attachments (7)

jctvc_hm.patch​ (17.1 KB) - added by kolya 8 years ago.
decoder patch
jctvc_hm_enc.patch​ (17.0 KB) - added by kolya 8 years ago.
encoder patch
1.patch​ (1.0 KB) - added by kolya 8 years ago.
1_enc.patch​ (872 bytes) - added by kolya 8 years ago.
2.patch​ (2.1 KB) - added by kolya 8 years ago.
2_encoder.patch​ (2.4 KB) - added by kolya 8 years ago.
bugfix.patch​ (4.2 KB) - added by kolya 8 years ago.
PTL naming patch

Download all attachments as: .zip

Change History (13)

comment:1 Changed 8 years ago by DefaultCC Plugin

  • Cc ksuehring davidf karlsharman jct-vc@… added

Changed 8 years ago by kolya

decoder patch

Changed 8 years ago by kolya

encoder patch

comment:2 Changed 8 years ago by ksuehring

Agreed. I tried to keep those in sync during the final phase of version 1 of the spec. Unfortunately editors don't send us patches when they decide to rename syntax elements :-(

Actually I would prefer to even go one step further and also properly name the variables and get/set functions in the related structures.

Changed 8 years ago by kolya

Changed 8 years ago by kolya

comment:3 Changed 8 years ago by kolya

Added naming fix patches for match debug string to the spec.

Changed 8 years ago by kolya

Changed 8 years ago by kolya

comment:4 Changed 8 years ago by kolya

Added more naming fixes.

Changed 8 years ago by kolya

PTL naming patch

comment:5 Changed 8 years ago by kolya

Added one more patch to fix naming for "general_" and "sub_layer_" prefixes in PTL parsing.

comment:6 Changed 8 years ago by karlsharman

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r4252. A new ticket (#1365) has been created to highlight that some renaming of variables and functions is needed in order to be consistent with the text.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Subscriber, Participant)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • Nikolay Shlyakhov(Reporter, Participant)