Opened 7 years ago

Closed 7 years ago

#1352 closed enhancement (fixed)

Ineffective QP loop in encodeResAndCalcRdInterCU

Reported by: karlsharman Owned by:
Priority: minor Milestone: HM-16.3
Component: HM Version: HM-16.2
Keywords: Cc: ksuehring, davidf, karlsharman, jct-vc@…

Description

As highlighted by TODOs patched in r4242, there is an ineffective QP loop in encodeResAndCalcRdInterCU.
QP looping is actually applied at a higher level.

This QP loop is:

1/ forced to loop over QP +/- 0 (max=min)
2/ does not change the QP,
3/ asserts if max!=min
4/ skip mode will be broken as it is not preserved during the search.

This should be removed.

Change History (2)

comment:1 Changed 7 years ago by DefaultCC Plugin

  • Cc ksuehring davidf karlsharman jct-vc@… added

comment:2 Changed 7 years ago by karlsharman

  • Milestone set to HM-16.3
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r4243

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Reporter, Subscriber, Participant)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)