Opened 4 years ago

Closed 3 years ago

#1343 closed enhancement (fixed)

HM should stop on unknown parameters

Reported by: ksuehring Owned by:
Priority: major Milestone: HM-16.4
Component: HM Version: HM-16.2
Keywords: Cc: ksuehring, davidf, karlsharman, jct-vc@…

Description

It has been requested that the HM encoder should fail when it encounters an unknown parameter.

The advantage is that when parameters get changed or renamed, old configuration files will fail instead of running with unexpected defaults.

HM currently only issues a warning.

Attachments (2)

0001-program_options-report-unknown-options-as-error.patch (14.6 KB) - added by davidf 3 years ago.
unknow_parmeters.patch (15.1 KB) - added by ksuehring 3 years ago.
updated patch with parameter to optionally warn only

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 years ago by DefaultCC Plugin

  • Cc ksuehring davidf karlsharman jct-vc@… added

comment:2 Changed 3 years ago by ksuehring

  • Milestone changed from HM-16.3 to HM-next

Changed 3 years ago by ksuehring

updated patch with parameter to optionally warn only

comment:4 Changed 3 years ago by ksuehring

As discussed privately before, I have added an option to restore the old behavior (only warn) using a command line option. The new patch adds "WarnUnknowParameter" or short "w" to the encoder, but does not change the output texts (i.e. "error").

The code can easily be replicated at the decoder.

comment:5 Changed 3 years ago by ksuehring

  • Resolution set to fixed
  • Status changed from new to closed

The patch (including the same parameter in the decoder) has been applied in r4339.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Subscriber, Always)
  • Karsten Suehring(Reporter, Subscriber, Participant, Always)