Opened 6 years ago

Closed 6 years ago

#1332 closed defect (fixed)

Double read of SEI byte alignment when payload extension present

Reported by: jackh Owned by:
Priority: minor Milestone: HM-16.2
Component: HM Version: HM-16.1
Keywords: Cc: ksuehring, davidf, karlsharman, jct-vc@…

Description

The reference code currently doesn't handle payload extensions in SEI messages correctly. In SEIread.cpp, each SEI parsing function calls xParseByteAlign() before returning. The payload extension decoding code (in SEIReader::xReadSEImessage(), line 328) then reads the payload extension followed by another alignment. According to the spec, the payload extension should be read before any alignnment. The reference code only fails when there is a payload extension present, as the code at the end of xReadSEImessage() only runs if there are bits remaining in the buffer.

The solution is to remove the calls to xParseByteAlign().

Change History (3)

comment:1 Changed 6 years ago by DefaultCC Plugin

  • Cc ksuehring davidf karlsharman jct-vc@… added

comment:2 Changed 6 years ago by ksuehring

  • Milestone HM-16.2 deleted

comment:3 Changed 6 years ago by ksuehring

  • Milestone set to HM-16.2
  • Resolution set to fixed
  • Status changed from new to closed

fixed in r4160

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Jack Haughton(Reporter)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)