Opened 4 years ago

Closed 4 years ago

#1318 closed defect (invalid)

Residual modification process doesn't match the spec

Reported by: jackh Owned by:
Priority: minor Milestone: HM+RExt-8.0
Component: HM RExt Version: RExt-7.2 (HM-14.0)
Keywords: Cc: davidf, karlsharman, jct-vc@…

Description

Line 1759 of TComTrQuant.cpp (function invRdpcmNxN) says:

        rdpcmMode = (uiChFinalMode == VER_IDX) ? RDPCM_VER : RDPCM_HOR;

I think this should be

        rdpcmMode = (uiChFinalMode >= VER_IDX) ? RDPCM_VER : RDPCM_HOR;

in order to match the Q1009 v9 spec, which says this should be predModeIntra / 26.

Change History (3)

comment:1 Changed 4 years ago by DefaultCC Plugin

  • Cc davidf karlsharman jct-vc@… added

comment:2 Changed 4 years ago by jackh

Sorry - this one isn't a bug as uiChFinalMode can only be VER_IDX or HOR_IDX in this block of code. Feel free to close this ticket.

comment:3 Changed 4 years ago by karlsharman

  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Jack Haughton(Reporter, Participant)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Subscriber, Participant, Always)
  • Karsten Suehring(Always)