Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#1283 closed enhancement (fixed)

check remaining bytes of slice segment data

Reported by: PhuongNguyen Owned by:
Priority: minor Milestone: HM-16.2
Component: HM Version: HM-14.0
Keywords: Cc: phuong_nguyen@…, fbossen, ksuehring, davidf, jct-vc@…

Description

The spec requires that once decoding end_of_slice_segment_flag with value 1, the remaining bytes in the slice segment data must not be different from zero. The attached patch adds this check.

Attachments (1)

check_zero.patch​ (4.9 KB) - added by PhuongNguyen 11 years ago.
source code patch

Download all attachments as: .zip

Change History (6)

comment:1 Changed 11 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 11 years ago by PhuongNguyen

source code patch

comment:2 Changed 11 years ago by PhuongNguyen

Actually, it seems that the conformance stream DBLK_A_MAIN10_VIXS_3.bit violates this point in the specs. The last byte in the stream is 0xff. It appears after the byte 0x30 used for decoding end_of_slice segment_flag equal to 1 and end of slice segment data, which is also end of stream. The last byte should be 0x00 instead of 0xff.

comment:3 Changed 11 years ago by ksuehring

  • Milestone HM-15.0 deleted

comment:4 Changed 10 years ago by karlsharman

  • Resolution set to fixed
  • Status changed from new to closed

Added in r4116.
DBLK_A_MAIN10_VIXS_3.bit fails, as highlighted.
Use macro DECODER_CHECK_SUBSTREAM_AND_SLICE_TRAILING_BYTES in TypeDef.h to disable/enable this feature (enabled by default).

comment:5 Changed 10 years ago by ksuehring

  • Milestone set to HM-16.2
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Participant)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • phuong_nguyen@…(Subscriber)