Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#1250 closed defect (invalid)

misleading loop limit

Reported by: kolya Owned by:
Priority: minor Milestone: HM-14.0
Component: HM Version: HM-13.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

in TEncSearch.cpp line 2489 there is numModesForFullRD, but numModesAvailable should be. Control must reach this line only if these two variables are equal.

Change History (3)

comment:1 Changed 8 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 8 years ago by fbossen

  • Resolution set to invalid
  • Status changed from new to closed

The loop is setting values in the array uiRdModeList:

      for( Int i=0; i < numModesForFullRD; i++)
      {
        uiRdModeList[i] = i;
      }

The loop bound is correct since it matches the loop bound of the loop reading from the array:

    for( UInt uiMode = 0; uiMode < numModesForFullRD; uiMode++ )
    {
      // set luma prediction mode
      UInt uiOrgMode = uiRdModeList[uiMode];


comment:3 Changed 8 years ago by kolya

in current code the loop on line 2489 can start only if limit is equal to 35 i.e. numModesAvailable (better to be declared as a const btw) set to 35 before

Last edited 8 years ago by kolya (previous) (diff)
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)
  • Nikolay Shlyakhov(Reporter, Participant)