Changes between Version 1 and Version 2 of Ticket #11


Ignore:
Timestamp:
Jul 23, 2010, 5:22:00 PM (14 years ago)
Author:
davidf
Comment:

It looks like the following is occuring in source/Lib/TLibCommon/TComLoopFilter.h: 

5b41c967 (Arild Fuldseth 2010-06-24 14:02:43 +0000  72) #if HHI_DEBLOCKING_FILTER || TENTM_DEBLOCKING_FILTER
...
5b41c967 (Arild Fuldseth 2010-06-24 14:02:43 +0000  87) #if PLANAR_INTRA
5b41c967 (Arild Fuldseth 2010-06-24 14:02:43 +0000  88)   Void xPelFilterPlanarIntra      ( Pel* piSrc, Int iOffset, Int iBlkSize );
5b41c967 (Arild Fuldseth 2010-06-24 14:02:43 +0000  89)   Void xEdgeFilterPlanarIntra     ( TComDataCU* pcCU, UInt uiAbsZorderIdx, Int iDir );
5b41c967 (Arild Fuldseth 2010-06-24 14:02:43 +0000  90) #endif
As this is from your integration, please can you confirm that the #PLANAR_INTRA block should be moved outside the "HHI_DEBLOCKING_FILTER
TENTM_DEBLOCKING_FILTER" prepr ocessor guard.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #11 – Description

    v1 v2  
    1 It looks like the following is occuring in source/Lib/TLibCommon/TComLoopFilter.h:
     1Build fails if using:
    22{{{
    3 5b41c967 (Arild Fuldseth 2010-06-24 14:02:43 +0000  72) #if HHI_DEBLOCKING_FILTER || TENTM_DEBLOCKING_FILTER
    4 ...
    5 5b41c967 (Arild Fuldseth 2010-06-24 14:02:43 +0000  87) #if PLANAR_INTRA
    6 5b41c967 (Arild Fuldseth 2010-06-24 14:02:43 +0000  88)   Void xPelFilterPlanarIntra      ( Pel* piSrc, Int iOffset, Int iBlkSize );
    7 5b41c967 (Arild Fuldseth 2010-06-24 14:02:43 +0000  89)   Void xEdgeFilterPlanarIntra     ( TComDataCU* pcCU, UInt uiAbsZorderIdx, Int iDir );
    8 5b41c967 (Arild Fuldseth 2010-06-24 14:02:43 +0000  90) #endif
     3#define ANG_INTRA 0
     4#define PLANAR_INTRA 1
     5#define TENTM_DEBLOCKING_FILTER 0
     6#define HHI_DEBLOCKING_FILTER 0
    97}}}
    108
    11 As this is from your integration, please can you confirm that the #PLANAR_INTRA block should be moved outside the "HHI_DEBLOCKING_FILTER || TENTM_DEBLOCKING_FILTER" prepr ocessor guard.
     9Build log:
     10{{{
     11source/Lib/TLibCommon/TComLoopFilter.cpp: In member function 'Void TComLoopFilter::xDeblockCU(TComDataCU*, UInt, UInt)':
     12source/Lib/TLibCommon/TComLoopFilter.cpp:198:64: error: 'xEdgeFilterPlanarIntra' was not declared in this scope
     13source/Lib/TLibCommon/TComLoopFilter.cpp:211:64: error: 'xEdgeFilterPlanarIntra' was not declared in this scope
     14}}}

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • arild.fuldseth@…(Subscriber)
  • David Flynn(Reporter, Owner, Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)