Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#1172 closed defect (fixed)

Encoding with IDR period fails

Reported by: ksuehring Owned by:
Priority: major Milestone: HM-16.1
Component: HM Version: HM-12.0
Keywords: Cc: fbossen, ksuehring, davidf, adarsh, jct-vc@…

Description

Encoding with

IntraPeriod > -1
DecodingRefreshType: 2

fails when checkLeadingPictureRestrictions() is called.

At the encoder rcListPic contains entries that are not previously coded pictures where checks are not useful.

Easiest fix would probably be to disable the check at the encoder.

Change History (7)

comment:1 Changed 8 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 7 years ago by fbossen

  • Milestone changed from HM-12.1 to HM-13.0
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r3781

comment:3 Changed 7 years ago by fbossen

  • Resolution fixed deleted
  • Status changed from closed to reopened

Patch appears to cause assert failure when using RA configuration with an intra period of 16.

POC   16 TId: 0 ( I-SLICE, nQP 32 QP 32 )      78568 bits [Y 42.1887 dB    U 45.8564 dB    V 47.4174 dB] [ET     4 ] [L0 ] [L1 ] [MD5:597e896e2146aa7258caf1ce5ff23919,911054f3e04705b95666a46ccaec4b9b,c9f23b7ee2bd4623de5416f0741c3061]
Assertion failed: (this->getPOC() > rpcPic->getSlice(0)->getPOC()), function checkLeadingPictureRestrictions, file HM-12.1-dev/build/linux/lib/TLibCommon/../../../../source/Lib/TLibCommon/TComSlice.cpp, line 952.

comment:4 Changed 7 years ago by fbossen

  • Resolution set to fixed
  • Status changed from reopened to closed

More comprehensive fix submitted in r3788

comment:5 Changed 7 years ago by ksuehring

  • Cc adarsh added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening this issue.

The fix seems to break interlace coding with the example interlace config file, when EFFICIENT_FIELD_IRAP is enabled.

The encoder crashes in the second GOP when it tries to write an invalid RPS.

If either EFFICIENT_FIELD_IRAP or FIX1172 is disabled, the encoder runs fine (with CRAs as IRAP).

It seems to be related to moving the code of the fix before the call to decodingRefreshMarking() in compressGOP(), when EFFICIENT_FIELD_IRAP is enabled.

comment:6 Changed 7 years ago by ksuehring

  • Resolution set to fixed
  • Status changed from reopened to closed

A fix for field coding has been applied in r4096

comment:7 Changed 7 years ago by ksuehring

  • Milestone changed from HM-13.0 to HM-16.1
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Adarsh Krishnan Ramasubramonian(Subscriber)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Reporter, Subscriber, Participant, Always)