Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#1150 closed enhancement (fixed)

Code tidy - missing inclusion guards on header files

Reported by: karlsharman Owned by:
Priority: trivial Milestone: HM-16.1
Component: HM Version: HM-12.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

The following header files are missing their inclusion guards:

(Lib/libmd5/libmd5.h)
(Lib/libmd5/MD5.h)
Lib/TLibCommon/NAL.h
Lib/TLibCommon/AccessUnit.h
Lib/TLibCommon/SEI.h
Lib/TLibEncoder/AnnexBwrite.h
Lib/TLibEncoder/NALwrite.h
Lib/TLibEncoder/SEIwrite.h
Lib/TAppCommon/program_options_lite.h
Lib/TLibDecoder/AnnexBread.h
Lib/TLibDecoder/NALread.h

Also, some other header files do not use the common HM naming for their guard macro:

i.e. _ _ <capitalised filename without the .h> _ _

Attachments (1)

patch_1150.txt (11.8 KB) - added by karlsharman 8 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 8 years ago by karlsharman

comment:2 Changed 8 years ago by davidf

With the exception of Lib/TAppCommon/program_options_lite.h, all are protected by #pragma once, the more modern and less error prone method.

comment:3 Changed 8 years ago by ksuehring

When drafting the coding style guide, we had decided that mandating guard macros would be more safe. I also don't think that we have a problem here because nobody should be using compilers anymore that don't understand #pragma once (let me know if this is a wrong assumption).

But even if we decide to not use guard macros anymore, we should be consistent in all files.

comment:4 Changed 7 years ago by fbossen

  • Type changed from defect to enhancement

comment:5 Changed 7 years ago by ksuehring

  • Milestone HM-12.1 deleted

comment:6 Changed 7 years ago by karlsharman

  • Resolution set to fixed
  • Status changed from new to closed

Fixed due to merger with RExt.

comment:7 Changed 7 years ago by ksuehring

  • Milestone set to HM-16.1
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Reporter, Participant)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)