Opened 8 years ago

Closed 8 years ago

#1124 closed defect (fixed)

Incorrect POC LSB Calculation

Reported by: bheng Owned by:
Priority: minor Milestone: HM-11.1
Component: HM Version: HM-11.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

The modulus (%) operator in C will incorrectly compute POC LSB when the POC value is negative.

The attached patch is one way to fix the issue.

Attachments (2)

poc_lsb.patch (619 bytes) - added by bheng 8 years ago.
poc_lsb_v2.patch (4.3 KB) - added by bheng 8 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 8 years ago by bheng

comment:2 Changed 8 years ago by jackh

We've also hit this bug. Similar modifications to the one in your patch should be made in TComSlice.cpp lines 238, 249, 840, 900, 919 and 920.

comment:3 Changed 8 years ago by bheng

The attached updated patch includes the additional changes you mentioned for long term pictures and a couple similar changes on the encode side.

Changed 8 years ago by bheng

comment:4 Changed 8 years ago by fbossen

  • Resolution set to fixed
  • Status changed from new to closed

Patch committed in r3519

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Brian Heng(Reporter, Participant)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • Jack Haughton(Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)