Opened 11 years ago Closed 11 years ago #1112 closed enhancement (wontfix)WS cleanup
Description
An enormous amount of trailing whitespace present in the codebase.
Patch against commit on trunk 2820ce9ee717f520cade57fb3bd71532d1eae544 $ git diff --stat trunk build/linux/app/TAppDecoder/makefile | 2 +- build/linux/lib/TLibVideoIO/makefile | 8 +- build/linux/makefile | 2 +- build/linux/utils/annexBbytecount/makefile | 2 +- build/linux/utils/convert_NtoMbit_YCbCr/makefile | 2 +- cfg/encoder_intra_main.cfg | 8 +- cfg/encoder_intra_main10.cfg | 8 +- cfg/encoder_lowdelay_P_main.cfg | 8 +- cfg/encoder_lowdelay_P_main10.cfg | 8 +- cfg/encoder_lowdelay_main.cfg | 8 +- cfg/encoder_lowdelay_main10.cfg | 8 +- cfg/encoder_randomaccess_main.cfg | 12 +- cfg/encoder_randomaccess_main10.cfg | 12 +- doc/mainpage.h | 6 +- doc/software-manual.tex | 88 ++++---- source/App/TAppDecoder/TAppDecCfg.cpp | 2 +- source/App/TAppDecoder/TAppDecCfg.h | 8 +- source/App/TAppDecoder/TAppDecTop.cpp | 40 ++-- source/App/TAppDecoder/TAppDecTop.h | 12 +- source/App/TAppDecoder/decmain.cpp | 2 +- source/App/TAppEncoder/TAppEncCfg.cpp | 138 ++++++------ source/App/TAppEncoder/TAppEncCfg.h | 34 +-- source/App/TAppEncoder/TAppEncTop.cpp | 72 +++--- source/App/TAppEncoder/TAppEncTop.h | 18 +- source/App/TAppEncoder/encmain.cpp | 2 +- source/App/utils/BitrateTargeting/ExtractBitrates.cpp | 44 ++-- source/App/utils/BitrateTargeting/ExtractBitrates.h | 8 +- source/App/utils/BitrateTargeting/ExtractBitratesMain.cpp | 12 +- source/App/utils/BitrateTargeting/GuessLambdaModifiers.cpp | 70 +++--- source/App/utils/BitrateTargeting/GuessLambdaModifiers.h | 2 +- source/App/utils/BitrateTargeting/GuessLambdaModifiersMain.cpp | 10 +- source/App/utils/BitrateTargeting/RuntimeError.h | 8 +- source/App/utils/BitrateTargeting/encodeCommand.sh | 8 +- source/App/utils/BitrateTargeting/makefile | 2 +- source/App/utils/BitrateTargeting/targetBitrates.sh | 42 ++-- source/App/utils/annexBbytecount.cpp | 2 +- source/App/utils/convert_NtoMbit_YCbCr.cpp | 6 +- source/Lib/TAppCommon/program_options_lite.cpp | 36 +-- source/Lib/TAppCommon/program_options_lite.h | 52 ++--- source/Lib/TLibCommon/AccessUnit.h | 2 +- source/Lib/TLibCommon/CommonDef.h | 10 +- source/Lib/TLibCommon/ContextModel.cpp | 2 +- source/Lib/TLibCommon/ContextModel.h | 16 +- source/Lib/TLibCommon/ContextModel3DBuffer.cpp | 4 +- source/Lib/TLibCommon/ContextModel3DBuffer.h | 10 +- source/Lib/TLibCommon/ContextTables.h | 260 +++++++++++----------- source/Lib/TLibCommon/NAL.h | 2 +- source/Lib/TLibCommon/SEI.cpp | 6 +- source/Lib/TLibCommon/SEI.h | 16 +- source/Lib/TLibCommon/TComBitCounter.h | 6 +- source/Lib/TLibCommon/TComBitStream.cpp | 4 +- source/Lib/TLibCommon/TComBitStream.h | 6 +- source/Lib/TLibCommon/TComCABACTables.cpp | 2 +- source/Lib/TLibCommon/TComCABACTables.h | 2 +- source/Lib/TLibCommon/TComDataCU.cpp | 542 +++++++++++++++++++++++----------------------- source/Lib/TLibCommon/TComDataCU.h | 148 ++++++------- source/Lib/TLibCommon/TComInterpolationFilter.cpp | 46 ++-- source/Lib/TLibCommon/TComInterpolationFilter.h | 6 +- source/Lib/TLibCommon/TComList.h | 14 +- source/Lib/TLibCommon/TComLoopFilter.cpp | 122 +++++------ source/Lib/TLibCommon/TComLoopFilter.h | 22 +- source/Lib/TLibCommon/TComMotionInfo.cpp | 34 +-- source/Lib/TLibCommon/TComMotionInfo.h | 36 +-- source/Lib/TLibCommon/TComMv.h | 38 ++-- source/Lib/TLibCommon/TComPattern.cpp | 70 +++--- source/Lib/TLibCommon/TComPattern.h | 30 +-- source/Lib/TLibCommon/TComPic.cpp | 26 +-- source/Lib/TLibCommon/TComPic.h | 32 +-- source/Lib/TLibCommon/TComPicSym.cpp | 32 +-- source/Lib/TLibCommon/TComPicSym.h | 22 +- source/Lib/TLibCommon/TComPicYuv.cpp | 74 +++---- source/Lib/TLibCommon/TComPicYuv.h | 54 ++--- source/Lib/TLibCommon/TComPrediction.cpp | 52 ++--- source/Lib/TLibCommon/TComPrediction.h | 26 +-- source/Lib/TLibCommon/TComRdCost.cpp | 278 ++++++++++++------------ source/Lib/TLibCommon/TComRdCost.h | 46 ++-- source/Lib/TLibCommon/TComRdCostWeightPrediction.cpp | 82 +++---- source/Lib/TLibCommon/TComRdCostWeightPrediction.h | 8 +- source/Lib/TLibCommon/TComRom.cpp | 40 ++-- source/Lib/TLibCommon/TComRom.h | 30 +-- source/Lib/TLibCommon/TComSampleAdaptiveOffset.cpp | 108 ++++----- source/Lib/TLibCommon/TComSampleAdaptiveOffset.h | 8 +- source/Lib/TLibCommon/TComSlice.cpp | 166 +++++++------- source/Lib/TLibCommon/TComSlice.h | 150 ++++++------- source/Lib/TLibCommon/TComTrQuant.cpp | 458 +++++++++++++++++++-------------------- source/Lib/TLibCommon/TComTrQuant.h | 96 ++++---- source/Lib/TLibCommon/TComWeightPrediction.cpp | 32 +-- source/Lib/TLibCommon/TComWeightPrediction.h | 4 +- source/Lib/TLibCommon/TComYuv.cpp | 112 +++++----- source/Lib/TLibCommon/TComYuv.h | 56 ++--- source/Lib/TLibCommon/TypeDef.h | 28 +-- source/Lib/TLibDecoder/AnnexBread.cpp | 4 +- source/Lib/TLibDecoder/NALread.cpp | 10 +- source/Lib/TLibDecoder/SEIread.cpp | 34 +-- source/Lib/TLibDecoder/SyntaxElementParser.cpp | 12 +- source/Lib/TLibDecoder/SyntaxElementParser.h | 2 +- source/Lib/TLibDecoder/TDecBinCoder.h | 4 +- source/Lib/TLibDecoder/TDecBinCoderCABAC.cpp | 38 ++-- source/Lib/TLibDecoder/TDecBinCoderCABAC.h | 12 +- source/Lib/TLibDecoder/TDecCAVLC.cpp | 162 +++++++------- source/Lib/TLibDecoder/TDecCAVLC.h | 18 +- source/Lib/TLibDecoder/TDecCu.cpp | 132 +++++------ source/Lib/TLibDecoder/TDecCu.h | 28 +-- source/Lib/TLibDecoder/TDecEntropy.cpp | 52 ++--- source/Lib/TLibDecoder/TDecEntropy.h | 42 ++-- source/Lib/TLibDecoder/TDecGop.cpp | 18 +- source/Lib/TLibDecoder/TDecGop.h | 18 +- source/Lib/TLibDecoder/TDecSbac.cpp | 150 ++++++------- source/Lib/TLibDecoder/TDecSbac.h | 30 +-- source/Lib/TLibDecoder/TDecSlice.cpp | 28 +-- source/Lib/TLibDecoder/TDecSlice.h | 10 +- source/Lib/TLibDecoder/TDecTop.cpp | 86 ++++---- source/Lib/TLibDecoder/TDecTop.h | 12 +- source/Lib/TLibEncoder/SEIwrite.cpp | 16 +- source/Lib/TLibEncoder/SyntaxElementWriter.cpp | 18 +- source/Lib/TLibEncoder/SyntaxElementWriter.h | 2 +- source/Lib/TLibEncoder/TEncAnalyze.cpp | 2 +- source/Lib/TLibEncoder/TEncAnalyze.h | 30 +-- source/Lib/TLibEncoder/TEncBinCoder.h | 4 +- source/Lib/TLibEncoder/TEncBinCoderCABAC.cpp | 40 ++-- source/Lib/TLibEncoder/TEncBinCoderCABAC.h | 18 +- source/Lib/TLibEncoder/TEncBinCoderCABACCounter.cpp | 4 +- source/Lib/TLibEncoder/TEncBinCoderCABACCounter.h | 6 +- source/Lib/TLibEncoder/TEncCavlc.cpp | 104 ++++----- source/Lib/TLibEncoder/TEncCavlc.h | 22 +- source/Lib/TLibEncoder/TEncCfg.h | 60 ++--- source/Lib/TLibEncoder/TEncCu.cpp | 186 ++++++++-------- source/Lib/TLibEncoder/TEncCu.h | 34 +-- source/Lib/TLibEncoder/TEncEntropy.cpp | 42 ++-- source/Lib/TLibEncoder/TEncEntropy.h | 24 +- source/Lib/TLibEncoder/TEncGOP.cpp | 270 +++++++++++------------ source/Lib/TLibEncoder/TEncGOP.h | 26 +-- source/Lib/TLibEncoder/TEncPic.cpp | 8 +- source/Lib/TLibEncoder/TEncPic.h | 4 +- source/Lib/TLibEncoder/TEncPreanalyzer.cpp | 2 +- source/Lib/TLibEncoder/TEncPreanalyzer.h | 2 +- source/Lib/TLibEncoder/TEncRateCtrl.cpp | 86 ++++---- source/Lib/TLibEncoder/TEncRateCtrl.h | 22 +- source/Lib/TLibEncoder/TEncSampleAdaptiveOffset.cpp | 262 +++++++++++----------- source/Lib/TLibEncoder/TEncSampleAdaptiveOffset.h | 30 +-- source/Lib/TLibEncoder/TEncSbac.cpp | 146 ++++++------- source/Lib/TLibEncoder/TEncSbac.h | 36 +-- source/Lib/TLibEncoder/TEncSearch.cpp | 962 ++++++++++++++++++++++++++++++++++++++++----------------------------------------- source/Lib/TLibEncoder/TEncSearch.h | 150 ++++++------- source/Lib/TLibEncoder/TEncSlice.cpp | 190 ++++++++-------- source/Lib/TLibEncoder/TEncSlice.h | 20 +- source/Lib/TLibEncoder/TEncTop.cpp | 86 ++++---- source/Lib/TLibEncoder/TEncTop.h | 26 +-- source/Lib/TLibEncoder/WeightPredAnalysis.cpp | 30 +-- source/Lib/TLibEncoder/WeightPredAnalysis.h | 2 +- source/Lib/TLibVideoIO/TVideoIOYuv.cpp | 30 +-- source/Lib/TLibVideoIO/TVideoIOYuv.h | 12 +- source/Lib/libmd5/MD5.h | 2 +- source/Lib/libmd5/libmd5.h | 2 +- 154 files changed, 4104 insertions(+), 4104 deletions(-) Attachments (1)Change History (4)comment:1 Changed 11 years ago by DefaultCC Plugin
Changed 11 years ago by fredrikpihlcomment:2 Changed 11 years ago by ksuehring
I actually don't see a strong need to clean up trailing whitespace. Compared to what you need to actually run the software, those extra bytes don't cost much.
On the other hand applying the patch would cause a lot of trouble for all extension projects which would have a hard time merging the base HM code unless they do the same cleanup. At least all automatic merges would fail.
I'm going to close the ticket as "won't fix" unless I hear strong argument for the cleanup. comment:3 Changed 11 years ago by ksuehring
Note: See
TracTickets for help on using
tickets. | This list contains all users that will be notified about changes made to this ticket. These roles will be notified: Reporter, Owner, Subscriber, Participant
| ||||||||||||||||
Powered by Trac 1.0.18
By Edgewall Software.
Visit the Trac open source project at
http://trac.edgewall.org/
git patch