Opened 8 years ago

Closed 8 years ago

#1093 closed defect (fixed)

bug fix for rate control

Reported by: libin Owned by:
Priority: minor Milestone: HM-11.0
Component: HM Version: HM-10.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

Thanks Wang, Xianglin (Shawn) for fixing a bug in r3493. The bug was introduced by M0036_RC_IMPROVEMENT.
But with that bug fix, the LCU level target bits are not set properly when getUseLCUSeparateModel() is false.
I think the attached patch is a better way to fix that bug.

Attachments (1)

Ticket1093.patch (1.3 KB) - added by libin 8 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 8 years ago by xianglinwang

There seems to be a typo in the bug fix code. Shall we change the "else" branch as follows?

Original fix:

else
{

alpha = m_encRCSeq->getPicPara( m_frameLevel ).m_alpha;
beta = m_encRCSeq->getPicPara( m_frameLevel ).m_beta;

}

Suggested:

else
{

alphaLCU = alpha;
betaLCU = beta;

}

Thanks
Shawn

comment:3 Changed 8 years ago by libin

Thanks for your fix. I think the modified patch could fix the problem.

Changed 8 years ago by libin

comment:4 Changed 8 years ago by fbossen

  • Milestone changed from HM-10.1 to HM-11.0
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r3494

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Bin Li(Reporter, Participant)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)
  • Xianglin(Shawn) Wang(Participant)