Opened 14 years ago

Closed 13 years ago

#106 closed defect (fixed)

Bug on mapping intra direction (from 34 to 9 case)

Reported by: wjhan Owned by:
Priority: minor Milestone:
Component: HM Version:
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

Jani reported the bug on mapping intra direction from 34 to 9 case.

In the case of conversion to 9 modes, horizontal mode with angle 7 (right-down variants) should be mapped to the mode 3 (right-down), but now it is mapped to mode 6 (left-down).

[TComRom.cpp]

const UChar g_aucAngModeMapping[3][34] = intra mode conversion for most probable
{

{2,3,2,2,4, 4,4,0,0,0, 0,0,0,0,2, 2,2,2,2,2, 2,1,1,1,1, 1,1,1,1,1, 2,2,2,2}, conversion to 5 modes
{2,3,3,2,4, 4,4,2,0,0, 0,2,5,5,5, 2,6,6,6,2, 7,7,7,2,1, 1,1,2,8,8, 8,2,2,2}, conversion to 9 modes
{2,3,3,10,10, 4,11,11,0,0, 0,12,12,5,5, 13,13,6,14,14, 7,7,15,15,1, 1,1,16,16,8, 8,2,2,9} conversion to 17 modes

};

should be

const UChar g_aucAngModeMapping[3][34] = intra mode conversion for most probable
{

{2,3,2,2,4, 4,4,0,0,0, 0,0,0,0,2, 2,2,2,2,2, 2,1,1,1,1, 1,1,1,1,1, 2,2,2,2}, conversion to 5 modes
{2,3,3,2,4, 4,4,2,0,0, 0,2,5,5,5, 2,6,6,3,2, 7,7,7,2,1, 1,1,2,8,8, 8,2,2,2}, conversion to 9 modes
{2,3,3,10,10, 4,11,11,0,0, 0,12,12,5,5, 13,13,6,14,14, 7,7,15,15,1, 1,1,16,16,8, 8,2,2,9} conversion to 17 modes

};

Change History (6)

comment:1 Changed 14 years ago by fbossen

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r314

comment:2 Changed 13 years ago by user.video1974

  • Cc user.video1974 added
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Summary changed from Bug on mapping intra direction (from 34 to 9 case) to Bug on mapping intra direction (from 34 to 9 case) and ADI mapping

In the output of the above data structure for g_aucAngModeMapping, which is the DC mode. For example, in the mapping from 34 to 17 modes, is the first entry i.e., 2 is for DC mode similar to H.264/AVC.

Also in the data structure below for ADI, g_aucAngIntraModeOrder, what do the 3 different columns mean. Which is the correct ordering of the modes in this data structure. Any explanation will be useful.

const UChar g_aucAngIntraModeOrder[34] =
{ ModeOrder LogicalOrderInPredFunctions

9, 0 VER DC

25, 1 HOR VER-8 (diagonal from top-left to bottom-right = HOR-8)

0, 2 DC VER-7
1, 3 VER-8 VER-6
5, 4 VER-4 VER-5

13, 5 VER+4 VER-4
17, 6 VER+8 VER-3
21, 7 HOR-4 VER-2
29, 8 HOR+4 VER-1
33, 9 HOR+8 VER

3, 10 VER-6 VER+1
7, 11 VER-2 VER+2

11, 12 VER+2 VER+3
15, 13 VER+6 VER+4
19, 14 HOR-6 VER+5
23, 15 HOR-2 VER+6
27, 16 HOR+2 VER+7
31, 17 HOR+6 VER+8

2, 18 VER-7 HOR-7
4, 19 VER-5 HOR-6
6, 20 VER-3 HOR-5
8, 21 VER-1 HOR-4

10, 22 VER+1 HOR-3
12, 23 VER+3 HOR-2
14, 24 VER+5 HOR-1
16, 25 VER+7 HOR
18, 26 HOR-7 HOR+1
20, 27 HOR-5 HOR+2
22, 28 HOR-3 HOR+3
24, 29 HOR-1 HOR+4
26, 30 HOR+1 HOR+5
28, 31 HOR+3 HOR+6
30, 32 HOR+5 HOR+7
32, 33 HOR+7 HOR+8

}

comment:3 Changed 13 years ago by fbossen

  • Cc user.video1974 removed
  • Resolution set to fixed
  • Status changed from reopened to closed
  • Summary changed from Bug on mapping intra direction (from 34 to 9 case) and ADI mapping to Bug on mapping intra direction (from 34 to 9 case)

Improperly reopened. Closing again... Questions such as the ones raised here should be directed to the jct-vc email reflector.

comment:4 Changed 12 years ago by davidf

  • Component set to HM

Updating component after adding WD (Text) tickets

comment:5 Changed 12 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:6 Changed 12 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)
  • Woo-Jin Han(Reporter)