Opened 9 years ago

Closed 9 years ago

#1021 closed defect (fixed)

Possible error in Sample Adaptive Offset for disabling chroma filtering between slices

Reported by: peterderivaz Owned by: bbross
Priority: minor Milestone:
Component: Text Version: D10 (L1003) v23
Keywords: Cc: bbross, wjhan, jct-vc@…

Description

In JCTVC-L1003_v24 "Coding tree block modification process" 8.7.3.2 the text constructs the modified sample locations in luma coordinates as

( xSYik′, ySYjk′ ) = ( xSYi + hPos[ k ], ySYj + vPos[ k ] ) (8 345)

However, for a chroma sample at xSi=31 and hPos[k]==1 we would get

xSYi = 31*2 = 62

xSYik' = xSYi + 1 = 62 + 1 = 63

and so when we compute the expression

MinTbAddrZs[ xSYik′ >> Log2MinTrafoSize ][ ySYjk′ >> Log2MinTrafoSize ]

we will end up examining the same transform block as the current sample and so neither condition which disable filtering across slices would activate.

This will mean that the chroma would end up filtering across the slice edge even if slice_loop_filter_across_slices_enabled_flag is equal to 0.

Change History (2)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc bbross wjhan jct-vc@… added

comment:2 Changed 9 years ago by bbross

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in current version v28.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Benjamin Bross(Owner, Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Always)
  • Peter de Rivaz(Reporter)
  • Woo-Jin Han(Subscriber)