Opened 14 years ago

Closed 9 years ago

Last modified 9 years ago

#101 closed enhancement (fixed)

Function getPartIndexAndSize() cannot be used at the decoder

Reported by: nsprljan Owned by:
Priority: minor Milestone: HM-16.3
Component: HM Version:
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

At the encoder CUs are split into smaller CUs and then the upper left corner of each CU can be indexed with a 0, instead with uiAbsPartIdx. In function getPartIndexAndSize() a fixed value of 0 is used instead of uiAbsPartIdx, which is fine as the function is currently only used at the encoder. At the decoder this kind of splitting is not performed, but the CUs are split by referencing to the positions in the LCU, so if this function is used it does not produce correct results. This can be fixed by replacing the zeroes at all required places with uiAbsPartIdx, and make that variable an input parameter to the function.

The modified function is provided in the attachment.

Attachments (1)

getPartIndexAndSize_with_uiAbsPartIdx.txt​ (2.1 KB) - added by nsprljan 14 years ago.

Download all attachments as: .zip

Change History (6)

Changed 14 years ago by nsprljan

comment:1 Changed 12 years ago by davidf

  • Component set to HM

Updating component after adding WD (Text) tickets

comment:2 Changed 12 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:3 Changed 12 years ago by davidf

  • Cc jct-vc@… added

comment:4 Changed 9 years ago by karlsharman

  • Resolution set to fixed
  • Status changed from new to closed

The function is (correctly) used by the decoder (for example by
TComPredicion::motionCompensation called by TDecCu::xReconInter).
Although the CU tree is traversed as described in the report, the leaf
CU nodes are explicitly formed in xDecompressCU prior to calls such as
xReconInter, allowing this function to be used safely in the decoder
for ascertaining sizes of PUs.

There is also no need to increase the flexibility of this function at
this time, and the supplied patch does not modify the use of
m_uiNumPartition.

A comment has been added in r4220 to the code to indicate that this function can
only be used for leaf/sub CU objects.

comment:5 Changed 9 years ago by karlsharman

  • Milestone set to HM-16.3

Batch modify of recently closed tickets to set milestone to HM-16.3.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Participant)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)
  • Nikola Sprljan(Reporter)