Opened 9 years ago

Closed 9 years ago

#1007 closed defect (fixed)

Invalid weighted prediction offsets

Reported by: bheng Owned by:
Priority: minor Milestone: HM-10.1
Component: HM Version: HM-9.2
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

The HM-10.0 encoder can generate luma weighted prediction offset values that are outside the valid range of [-128,127].

The attached patch can be used to fix this issue. This patch also adds range checking on the decode side to detect similar issues in the future.

Attachments (2)

weighted_pred_range.patch (3.0 KB) - added by bheng 9 years ago.
weighted_pred_range_r1.patch (3.1 KB) - added by Tanizawa 9 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 9 years ago by bheng

comment:2 Changed 9 years ago by Tanizawa

Hi, I think your pointing out is right.

Additionally, the range limitation of chroma weighted prediction offset for the encoder should be modified as follows.

  • Int shift = 1 << (g_bitDepthC - 1);
  • Int pred = ( shift - ( ( shift*weight)>>(log2Denom) ) );
  • Int pred = ( 128 - ( ( 128*weight)>>(log2Denom) ) );

The attached patch can be used to fix this issue on the top of weighted_pred_range.patch.

Changed 9 years ago by Tanizawa

comment:3 Changed 9 years ago by fbossen

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r3374

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Brian Heng(Reporter)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)