Opened 5 years ago

Last modified 4 years ago

#94 new clean up required

LayerIdIncludedFlag are not set correcly

Reported by: hallapur Owned by: tech
Priority: minor Component: HTM software
Version: HTM-13.0 Keywords:
Cc: tech, jct-3v@…

Description

LayerIdIncludedFlags are set in TAppEncTop.cpp as follows:

vps.setLayerIdIncludedFlag(true, lsIdx, vps.getLayerIdInNuh(m_layerIdsInSets[lsIdx][i]));

However, m_layerIdsInSets does not contain indices as assumed but layer IDs. Therefore, the correct way to set the flags is:

vps.setLayerIdIncludedFlag(true, lsIdx, m_layerIdsInSets[lsIdx][i]);

Change history (2)

comment:1 Changed 5 years ago by DefaultCC Plugin

  • Cc tech jct-3v@… added

comment:2 Changed 4 years ago by tech

  • Type changed from defect to clean up required

Due to the cfg-file comment m_layerIdsInSets should include layer indices in VPS and not nuh_layer_id values. Therefore, this is not a bug. However, the variable name m_layerIdsInSets should be changed to e.g. m_vpsLayerIdxInSet to reflect this.

Changed ticket to cleanup.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Gerhard Tech(Owner, Subscriber, Participant, Always)
  • hallapur(Reporter)
  • jct-3v@…(Subscriber)
  • Karsten Suehring(Always)