Opened 7 years ago

Closed 7 years ago

#67 closed defect (fixed)

Redundant DBBP flag setting for 2NxN parition

Reported by: jicheng Owned by: tech
Priority: minor Component: HTM software
Version: HTM-10.1 Keywords: DBBP flag setting
Cc: tech, jct-3v@…

Description

In the function parseDBBPFlag() of HTM11.0, the following code

#if MTK_DIS_SPBIP8X4_H0205
    UInt uiCurrPartNumQ = (pcCU->getPic()->getNumPartInCU() >> (2 * uiDepth)) >> 2;
    pcCU->setDBBPFlagSubParts(true, uiAbsPartIdx + 2*uiCurrPartNumQ, 1, uiDepth);
#endif

is originally intended to set the DBBP flag for the 2nd part of the 2NxN PU.

However, currently the DBBP flag is set outside of this function for all kinds of paritions. Therefore, the above code is redundant.

In addition, if the macro RWTH_DBBP_PACK_MODE is not 2NxN (encoder issue, since for DBBP mode, there is no restriction for partition size), the above code may set the wrong DBBP flag.
Therefore, the above code should be removed. There will be no performance impact for CTC.

Change history (2)

comment:1 Changed 7 years ago by DefaultCC Plugin

  • Cc tech jct-3v@… added

comment:2 Changed 7 years ago by tech

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Gerhard Tech(Owner, Subscriber, Participant, Always)
  • jct-3v@…(Subscriber)
  • Jicheng(Reporter)
  • Karsten Suehring(Always)