Opened 8 years ago

Closed 8 years ago

#56 closed defect (fixed)

A bug caused by uncompressed InterDir in HTM10.0rc1

Reported by: kaizhang Owned by: tech
Priority: minor Component: HTM software
Version: HTM-10.0 Keywords: software bug
Cc: gerhard.tech@…, tech, jct-3v@…

Description

A bug is found in HTM10.0rc1. Generally speaking, the original code tries to use InterDir to determine the prediction direction. However, InterDir is not compressed as MV and RefIdx. Thus a misalignment may occur. In some worse case, the codec may crash, although that does not happen in CTC.
Attached please find a possible fix with macro HTM10RC1_FIX and the simulation results under CTC. There is a very minor difference (<0.001%) in the last column.

At line 4746 in TComDataCU.cpp, it should be
#if !HTM10RC1_FIX

if( ucInterDir & 1 )
{

#endif

pcTextureCU->getMvField( pcTextureCU, uiPartIdx, REF_PIC_LIST_0, cMVField );

#if HTM10RC1_FIX

if( cMVField.getRefIdx() >= 0 )
{

#endif
...

At line 4775 in TComDataCU.cpp, it should be

#if !HTM10RC1_FIX

if( !tmpDir && ( ucInterDir & 2 ))
{

#endif

pcTextureCU->getMvField( pcTextureCU, uiPartIdx, REF_PIC_LIST_1, cMVField );

#if HTM10RC1_FIX

if( !tmpDir && cMVField.getRefIdx() >= 0 )
{

#endif

Thank you!

Attachments (2)

TypeDef.h (37.4 KB) - added by kaizhang 8 years ago.
10.0rcFix.zip (174.3 KB) - added by kaizhang 8 years ago.

Download all attachments as: .zip

Change history (6)

comment:1 Changed 8 years ago by DefaultCC Plugin

  • Cc tech jct-3v@… added

Changed 8 years ago by kaizhang

Changed 8 years ago by kaizhang

comment:2 Changed 8 years ago by tech

  • Version set to HTM-10.0

comment:3 Changed 8 years ago by fabianjaeger

What do we do about this bug? I have a proposal, which would crash if the bug fix is not applied. Do we also need to change the anchor then?

Last edited 8 years ago by fabianjaeger (previous) (diff)

comment:4 Changed 8 years ago by tech

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Fabian Jäger(Participant)
  • Gerhard Tech(Owner, Subscriber, Participant, Always)
  • jct-3v@…(Subscriber)
  • Kai Zhang(Reporter)
  • Karsten Suehring(Always)